Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a page on ffi #1571

Merged
merged 10 commits into from
Mar 18, 2025
Merged

adding a page on ffi #1571

merged 10 commits into from
Mar 18, 2025

Conversation

thisisjofrank
Copy link
Collaborator

@thisisjofrank thisisjofrank commented Mar 18, 2025 •
edited
Loading

Adding a new page to docs on FFI
Referencing new page in security page
Fixing a broken link

@thisisjofrank thisisjofrank marked this pull request as ready for review March 18, 2025 10:59
@thisisjofrank thisisjofrank requested review from littledivy and ry March 18, 2025 10:59
littledivy
littledivy reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Thanks for adding these docs!

littledivy
littledivy approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ry
ry requested changes Mar 18, 2025
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to take an edit pass before landing

ry
ry approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit b07d2e4 into main Mar 18, 2025
4 checks passed
@ry ry deleted the ffi branch March 18, 2025 17:42
@thisisjofrank thisisjofrank mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisjofrank @ry @littledivy